feat: add CheckedOpRewritePattern & CheckedOpTraitRewritePattern
#960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/optimization_overrides
branch
from
c9d0521 to
a935b8a
Compare
wsmoses
reviewed
May 18, 2025
wsmoses
reviewed
May 18, 2025
wsmoses
reviewed
May 18, 2025
wsmoses
reviewed
May 18, 2025
ftynse
reviewed
May 19, 2025
| if (res.failed()) | ||
| return res; | ||
|
|
||
| if (!((Child *)this)->supportsDynamicShapes()) { |
There was a problem hiding this comment.
I don't see much value in CRTP here. The classes already have a vtable and we get to patterns through a vitrual call. A couple more won't change much, and I don't think the pattern infra cost is dominated by virtual calls. Maintainability-wise, it will be easier without.
Also, it may be worth it to declare matchAndRewrite final.
There was a problem hiding this comment.
@wsmoses what do you think?
There was a problem hiding this comment.
I'm okay either way, slight pref to leave as CRTP for ease/perf [esp since we already have]
There was a problem hiding this comment.
In that case we can probably merge. All the other comments should have been addressed
wsmoses
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supportsDynamicShapes()-- opt in for patterns that support dynamic shapes. Once all patterns do we can switch the defaultdisablePatternAttrName()-- allows providing a UnitAttr to the enclosing funcOpInterface to disable patterns. defaults to"enzymexla.disable_hlo_opts"