Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindBugs fix; Windows build fix. #271

Merged
merged 6 commits into from
Jan 7, 2017
Merged

FindBugs fix; Windows build fix. #271

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
662e33e
Fix FindBugs warning in ApplicationContextHolder.
cameronxm Oct 19, 2016
f24a74b
Workaround for failing tests on Windows. TODO: Raise ticket to make
cameronxm Oct 19, 2016
628d928
Workaround for failing tests on Windows. TODO: Raise ticket to make
cameronxm Oct 19, 2016
8cb4964
Commit.
cameronxm Oct 19, 2016
c766e57
Fix whitespace per PR review comments.
cameronxm Oct 20, 2016
c386ab8
Increase code coverage (now 91%).
cameronxm Oct 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Workaround for failing tests on Windows. TODO: Raise ticket to make 
tests platform-independent.
  • Loading branch information
@cameronxm
cameronxm committed Oct 19, 2016
commit 628d92875758d0e2795e7d7070c976dd798b9030
3 changes: 2 additions & 1 deletion src/test/java/FizzBuzzTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ private void doFizzBuzz(final int n, final String s) throws IOException {
this.fb.fizzBuzz(n);

System.out.flush();
assertEquals(s, baos.toString());
final String platformDependentExpectedResult = s.replaceAll("\\n", System.getProperty("line.separator"));
assertEquals(platformDependentExpectedResult, baos.toString());
}

@Test
Expand Down