Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup_pgd pgd_commit_scopes default empty list #589

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

mw2q
Copy link
Contributor

@mw2q mw2q commented Sep 5, 2023

The default value for pgd_commit_scopes should be an empty list as opposed to an empty string because all of the validations are written for lists as opposed to strings.

The default value for pgd_commit_scopes should be an empty list as
opposed to an empty string because all of the validations are written
for lists as opposed to strings.
Copy link
Contributor

@dougortiz dougortiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@vibhorkumar123 vibhorkumar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vibhorkumar123 vibhorkumar123 merged commit ee7f1d5 into EnterpriseDB:main Sep 6, 2023
16 checks passed
@mw2q mw2q deleted the pgd branch September 6, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants