Utils unit test #837
Closed
Utils unit test #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as' or 'waivers') based on the test needs. This bypasses the internal check because the test would fail due to the correct expected authority.
This reverts commit 7b18bb1.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The importance of testing our code goes without saying. At the time we were moving fast and “breaking” things so to speak, but now in an effort to really mature MAKO and start to prepare for production we would like to improve not only test coverage but also the general stability of our code.
A lot of our newer code has unit tests built in, but that leaves some of the older rough edges to be tested. The fact of the matter is we are still developing against this older cold and in doing so it can be quite flaky. We would like to take the first step and unit test the building blocks so that we can confidently grow the code base into the future.
The following utils should pass unit testing. The complexity is identified in the title of the story.
createContextProvider
crumbs
date (file can be removed)
formOrigin
location
stateNames
textHelpers
utils_
Linked Issues to Close
Links to issue(s) that are closed by this PR. Be sure to use the phrase "Closes #XXX" for each issue, so they automatically close
Approach
stateNames (review)
textHelpers (review)
utils (review)
formOrigin (review)
crumbs (review)
date (file was deleted as it could be removed)
Assorted Notes/Considerations/Learning
createContextProvider (can be removed in the future, doesn't need to be tested according to Brian and Asharon
location (will be removed for it's own ticket)
utils (has unit testing already, doesn't need to be tested)