Fix error handling to distinguish Error objects from primitive throws#2148
Merged
sharjeelyunus merged 4 commits intomainfrom Jan 13, 2026
Merged
Fix error handling to distinguish Error objects from primitive throws#2148sharjeelyunus merged 4 commits intomainfrom
sharjeelyunus merged 4 commits intomainfrom
Conversation
- Add isErrorObject flag to JSCustomException to track if error was created via new Error() - Keep Error objects wrapped to preserve .message property access - Unwrap primitive throws (strings, numbers) to their raw values - Add comprehensive tests for Error objects vs primitive throw behavior - Update .gitignore to exclude Flutter-generated files in example apps 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Member
|
LGTM. However, these changes should live in The current ensemble runtime uses the new path ( For more details, please refer to the Packages Migration documentation (still in progress) as we continue moving all ensemble packages to standalone, pub.dev–published packages: |
- Added isErrorObject flag to JSCustomException to differentiate between Error objects and primitive throws. - Updated exception handling in JSInterpreter to preserve Error objects while unwrapping primitive throws. - Ensured that the toString method returns an empty string for null values.
- Released version 1.0.7, fixing an issue where Error objects were not being properly unwrapped in catch clauses.
- Updated ensemble_ts_interpreter dependency across multiple modules to version 1.0.7, addressing error handling improvements and ensuring consistency in dependency management.
sharjeelyunus
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves JavaScript error handling in the TS interpreter to properly distinguish between Error objects and primitive throws:
new Error()) are now kept asJSCustomExceptionto preserve their object nature and allow access to the.messagepropertyChanges
isErrorObjectflag toJSCustomExceptionclass to track error creation methodnewjs_interpreter.dartto conditionally wrap/unwrap based on error type.gitignoreto exclude Flutter-generated files in example appsTest plan
.messageproperty access🤖 Generated with Claude Code