Skip to content

update filename extension for script artifacts #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

anserwaseem
Copy link
Collaborator

Describe your changes

filename extension for scripts is .yaml too. this PR changes it to .js

Screenshots [Optional]

Issue ticket number and link

Closes #

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests
  • I have added a changeset pnpm changeset add
  • I have added example usage in the kitchen sink app

@anserwaseem anserwaseem requested a review from evshi February 6, 2025 17:41
@anserwaseem anserwaseem self-assigned this Feb 6, 2025
Copy link

changeset-bot bot commented Feb 6, 2025

🦋 Changeset detected

Latest commit: a04c143

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ensembleui/js-commons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Visit the preview URL for this PR (updated for commit a04c143):

https://react-kitchen-sink-dev--pr1028-anserwaseem-scripts-cpeb8viy.web.app

(expires Thu, 13 Feb 2025 17:45:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9

@anserwaseem anserwaseem merged commit 3ad8540 into main Feb 6, 2025
3 checks passed
@anserwaseem anserwaseem deleted the anserwaseem/scripts-extension branch February 6, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants