Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid smartmatch #1461

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Avoid smartmatch #1461

merged 1 commit into from
Aug 3, 2023

Conversation

nuno-agostinho
Copy link
Contributor

@nuno-agostinho nuno-agostinho commented Jul 24, 2023 •
edited
Loading

Smartmatch is an experimental feature that throws warnings in newer versions of Perl. This PR intends to replace a smart match with an equivalent if statement.

@dglemos dglemos self-requested a review July 24, 2023 10:53
@dglemos dglemos self-assigned this Jul 24, 2023
@nuno-agostinho nuno-agostinho marked this pull request as ready for review July 27, 2023 09:39
@dglemos dglemos merged commit bd26a56 into Ensembl:postreleasefix/111 Aug 3, 2023
@dglemos
Copy link
Contributor

dglemos commented Aug 3, 2023

Merged into release/111 and main

@nuno-agostinho nuno-agostinho deleted the fix/smartmatch branch August 3, 2023 13:12
@FedericaBrando FedericaBrando mentioned this pull request Oct 10, 2023
Closed
@sgiorgetti sgiorgetti mentioned this pull request Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dglemos dglemos dglemos approved these changes

Assignees

@dglemos dglemos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nuno-agostinho @dglemos