Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix results when enabling --no_stats #1427

Draft
wants to merge 1 commit into
base: postreleasefix/111
Choose a base branch
from

Conversation

nuno-agostinho
Copy link
Contributor

@nuno-agostinho nuno-agostinho commented Jun 2, 2023

ENSVAR-4494: related with #1034

When running --no_stats, consequences for --hgvs can be wrongly calculated. This PR adds missing logic required when running --no_stats to return the expected results.

However, this adds extra steps that can make VEP slower with -no_stats -- we need to benchmark how slow adding this can be for a large amount of variants.

Testing

Running with or without --no_stats --hgvs should return the same results when using the following input VCF:

#CHROM	POS	ID	REF	ALT	QUAL	FILTER	INFO	FORMAT
chr3	42210085	.	C	CGGAGGA,CGGA	359	PASS	.
chr14	24300643	.	A	AGAGGAG,AGAG	694	PASS	.

@nuno-agostinho nuno-agostinho changed the base branch from postreleasefix/110 to postreleasefix/111 June 26, 2023 13:39
@serge2016
Copy link

Hello! Hope to see update here very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants