Change self-collision behaviour to be consistent with edge-collision. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colliding with self now triggers the death animation, instead of calling self.reset() immediately, which was buggy and caused the snake to persist between "lives".
|
Thank you for pointing this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when you collided with yourself, it would call self.reset() instantly, which would cause the snake to reset to the starting position but would not play the death animation or destroy the old body.
This PR changes it to set self.dead to True, same as how it is done when colliding with screen borders. This causes it to play the death animation and properly reset the snake (same as it does when you hit the screen borders).