Skip to content

Conversation

@me4502
Copy link
Member

@me4502 me4502 commented Dec 28, 2022

This is a refactor to allow access to a ParserContext within the suggestion methods. This is required for any suggestions within the factory parser that are player-specific, such as suggesting properties for the currently held block in //set hand[layers=6] or whatever

@me4502 me4502 requested a review from a team December 28, 2022 11:56
@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Merging #2236 (d6ce553) into master (6951e79) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             master   #2236      +/-   ##
===========================================
- Coverage      9.20%   9.20%   -0.01%     
  Complexity     1038    1038              
===========================================
  Files           871     871              
  Lines         43653   43658       +5     
  Branches       4870    4870              
===========================================
  Hits           4019    4019              
- Misses        39453   39458       +5     
  Partials        181     181              
Impacted Files Coverage Δ
...q/worldedit/command/argument/FactoryConverter.java 23.40% <0.00%> (-1.60%) ⬇️
...sk89q/worldedit/extension/factory/MaskFactory.java 38.46% <0.00%> (ø)
...xtension/factory/parser/mask/BlocksMaskParser.java 16.66% <0.00%> (ø)
...xtension/factory/parser/mask/NegateMaskParser.java 16.66% <0.00%> (ø)
...xtension/factory/parser/mask/OffsetMaskParser.java 13.33% <0.00%> (ø)
...on/factory/parser/pattern/RandomPatternParser.java 8.57% <0.00%> (ø)
...ctory/parser/pattern/RandomStatePatternParser.java 11.11% <0.00%> (ø)
...ctory/parser/pattern/SingleBlockPatternParser.java 50.00% <0.00%> (ø)
...rser/pattern/TypeOrStateApplyingPatternParser.java 4.16% <0.00%> (ø)
...q/worldedit/internal/registry/AbstractFactory.java 47.61% <0.00%> (-2.39%) ⬇️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@octylFractal octylFractal added this to the 7.3.0 milestone Feb 20, 2023
@me4502 me4502 merged commit 98fd5dc into master Feb 26, 2023
@me4502 me4502 deleted the chore/allow-suggestions-to-have-context branch February 26, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants