Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update WorldEdit to Sponge 8 #1289

Closed
wants to merge 2 commits into from
Closed

[WIP] Update WorldEdit to Sponge 8 #1289

wants to merge 2 commits into from

Conversation

me4502
Copy link
Member

@me4502 me4502 commented Apr 10, 2020

Sponge API 8 is not yet out - this PR is a work in progress to test out the new API and find any issues before it is finalised.

Required Tasks:

  • Re-add bStats
  • Fix up logger
  • Fix up various hacky systems for blockstate string parsing support
  • Setup adapters / WNA / SideEffects

Waiting on a few Sponge changes:

Implementation of PaletteType for GLOBAL_BLOCKS

@octylFractal octylFractal added platform:sponge Specific to the Sponge platform status:accepted Will be fixed / added to WorldEdit, eventually labels Apr 16, 2020
@me4502 me4502 force-pushed the sponge-8 branch 2 times, most recently from 6fb8213 to 458ebda Compare August 28, 2020 13:24
@codecov
Copy link

codecov bot commented Aug 29, 2020

Codecov Report

Merging #1289 (e043b77) into master (913d4d6) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1289      +/-   ##
============================================
- Coverage     11.44%   11.40%   -0.05%     
  Complexity     1002     1002              
============================================
  Files           805      809       +4     
  Lines         32598    32720     +122     
  Branches       3783     3804      +21     
============================================
  Hits           3732     3732              
- Misses        28688    28810     +122     
  Partials        178      178              
Impacted Files Coverage Δ Complexity Δ
.../com/sk89q/worldedit/extension/platform/Actor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../com/sk89q/worldedit/sponge/CUIChannelHandler.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ava/com/sk89q/worldedit/sponge/CommandAdapter.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...java/com/sk89q/worldedit/sponge/SpongeAdapter.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...om/sk89q/worldedit/sponge/SpongeCommandSender.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/com/sk89q/worldedit/sponge/SpongeEntity.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...sk89q/worldedit/sponge/SpongeEntityProperties.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...9q/worldedit/sponge/SpongePermissionsProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ava/com/sk89q/worldedit/sponge/SpongePlatform.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/com/sk89q/worldedit/sponge/SpongePlayer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 913d4d6...e043b77. Read the comment docs.

@me4502 me4502 closed this Aug 22, 2021
@me4502 me4502 deleted the sponge-8 branch June 17, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:sponge Specific to the Sponge platform status:accepted Will be fixed / added to WorldEdit, eventually type:feature-request Request for something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants