Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SuggestionProvider] Highlight locally executed actions when remote execution is used #119

Merged
merged 1 commit into from
Nov 24, 2023
Merged

[SuggestionProvider] Highlight locally executed actions when remote execution is used #119

merged 1 commit into from
Nov 24, 2023

Conversation

saraadams
Copy link
Collaborator

Add a SuggestionProvider which, if remote execution is used, highlights which actions were run locally and suggests migrating them to remote execution, too. In default mode, the four longest local actions are listed.

Fixes #95.

@saraadams
[SuggestionProvider] Highlight locally executed actions when remote e…
e32029a 
…xecution is used

Add a `SuggestionProvider` which, if remote execution is used, highlights which actions
were run locally and suggests migrating them to remote execution, too.
In default mode, the four longest local actions are listed.

Fixes #95.

Signed-off-by: Sara Adams <sara.e.adams@gmail.com>
@saraadams
Copy link
Collaborator Author

Example output:

Suggestion: "Migrate locally executed actions to remote execution"
Although remote execution was used for this invocation, some actions were still executed locally. Investigate whether you can migrate these actions to remote execution to speed up future builds and improve hermeticity:
	- Executing genrule //src:target_b (23ms)
Screenshot 2023-11-24 at 17 16 27 (2)

WillEngFlow
WillEngFlow approved these changes Nov 24, 2023
View reviewed changes
Copy link

@WillEngFlow WillEngFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice win!

@saraadams saraadams merged commit 7c4feb5 into main Nov 24, 2023
3 checks passed
@saraadams saraadams deleted the sara-make-local-actions-remote branch November 24, 2023 19:35
saraadams added a commit that referenced this pull request Nov 25, 2023
@saraadams
[LocalActionsWithRemoteExecutionSuggestionProvider] Fix bug where emp…
4e7e135 
…ty suggestions were included

This change includes a fix, where empty suggestions were added if
* the invocation used remote execution
* no actions were executed locally.

Follow-up to #119
Contributes to #95
saraadams added a commit that referenced this pull request Nov 25, 2023
@saraadams
[LocalActionsWithRemoteExecutionSuggestionProvider] Fix bug where emp…
e5773e6 
…ty suggestions were included

This change includes a fix, where empty suggestions were added if
* the invocation used remote execution
* no actions were executed locally.

Follow-up to #119
Contributes to #95

Signed-off-by: Sara Adams <sara.e.adams@gmail.com>
@saraadams saraadams mentioned this pull request Nov 25, 2023
Merged
saraadams added a commit that referenced this pull request Nov 27, 2023
@saraadams
[LocalActionsWithRemoteExecutionSuggestionProvider] Fix bug where emp…
84392c1 
…ty suggestions were included (#123)

This change includes a fix, where empty suggestions were added if
* the invocation used remote execution
* no actions were executed locally.

Follow-up to #119
Contributes to #95

Signed-off-by: Sara Adams <sara.e.adams@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillEngFlow WillEngFlow WillEngFlow approved these changes

@lrgoldstein lrgoldstein Awaiting requested review from lrgoldstein

@restingbull restingbull Awaiting requested review from restingbull

@TheGrizzlyDev TheGrizzlyDev Awaiting requested review from TheGrizzlyDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Highlight local actions if remote execution is used
2 participants
@saraadams @WillEngFlow