Skip to content

Commit

Permalink
Revert "refactor(platform-browser): move platform-browser/animations …
Browse files Browse the repository at this point in the history
…to animations/browser (angular#15043)"

This reverts commit 195b863.
  • Loading branch information
chuckjaz committed Mar 13, 2017
1 parent 498a951 commit e6c81d2
Show file tree
Hide file tree
Showing 58 changed files with 84 additions and 210 deletions.
9 changes: 0 additions & 9 deletions packages/animations/browser/.babelrc-browser

This file was deleted.

11 changes: 0 additions & 11 deletions packages/animations/browser/.babelrc-browser-testing

This file was deleted.

14 changes: 0 additions & 14 deletions packages/animations/browser/index.ts

This file was deleted.

14 changes: 0 additions & 14 deletions packages/animations/browser/public_api.ts

This file was deleted.

15 changes: 0 additions & 15 deletions packages/animations/browser/src/browser.ts

This file was deleted.

15 changes: 0 additions & 15 deletions packages/animations/browser/src/private_export.ts

This file was deleted.

18 changes: 0 additions & 18 deletions packages/animations/browser/testing/tsconfig-build.json

This file was deleted.

21 changes: 0 additions & 21 deletions packages/animations/browser/tsconfig-build.json

This file was deleted.

16 changes: 1 addition & 15 deletions packages/animations/src/version.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,21 +12,7 @@
* Entry point for all public APIs of the animation package.
*/

/**
* @whatItDoes Represents the version of angular/animations
*
* @stable
*/
export class Version {
constructor(public full: string) {}

get major(): string { return this.full.split('.')[0]; }

get minor(): string { return this.full.split('.')[1]; }

get patch(): string { return this.full.split('.').slice(2).join('.'); }
}

import {Version} from '@angular/core';
/**
* @stable
*/
Expand Down
8 changes: 5 additions & 3 deletions packages/animations/tsconfig-build.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@
"experimentalDecorators": true,
"module": "es2015",
"moduleResolution": "node",
"outDir": "../../../dist/packages-dist/animations",
"outDir": "../../dist/packages/animations",
"paths": {
"@angular/core": ["../../dist/packages/core"],
"@angular/core/testing": ["../../dist/packages/core/testing"]
},
"rootDir": ".",
"sourceMap": true,
Expand All @@ -20,8 +22,8 @@
},
"files": [
"public_api.ts",
"../../../node_modules/zone.js/dist/zone.js.d.ts",
"../../system.d.ts"
"../../node_modules/zone.js/dist/zone.js.d.ts",
"../system.d.ts"
],
"angularCompilerOptions": {
"annotateForClosureCompiler": true,
Expand Down
3 changes: 1 addition & 2 deletions packages/compiler-cli/integrationtest/src/module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,9 @@
* found in the LICENSE file at https://angular.io/license
*/

import {ɵAnimationEngine} from '@angular/animations/browser';
import {ApplicationRef, NgModule, NgZone, Provider, RendererFactory2} from '@angular/core';
import {FormsModule} from '@angular/forms';
import {NoopAnimationsModule, ɵAnimationRendererFactory} from '@angular/platform-browser/animations';
import {NoopAnimationsModule, ɵAnimationEngine, ɵAnimationRendererFactory} from '@angular/platform-browser/animations';
import {ServerModule, ɵServerRendererFactory2} from '@angular/platform-server';
import {MdButtonModule} from '@angular2-material/button';
// Note: don't refer to third_party_src as we want to test that
Expand Down
5 changes: 2 additions & 3 deletions packages/core/test/animation/animation_integration_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,10 @@
* found in the LICENSE file at https://angular.io/license
*/
import {AUTO_STYLE, AnimationEvent, animate, keyframes, state, style, transition, trigger} from '@angular/animations';
import {AnimationDriver, ɵAnimationEngine} from '@angular/animations/browser';
import {MockAnimationDriver, MockAnimationPlayer} from '@angular/animations/browser/testing';
import {Component, HostBinding, HostListener, RendererFactory2, ViewChild} from '@angular/core';
import {ɵDomRendererFactory2} from '@angular/platform-browser';
import {BrowserAnimationsModule} from '@angular/platform-browser/animations';
import {AnimationDriver, BrowserAnimationsModule, ɵAnimationEngine} from '@angular/platform-browser/animations';
import {MockAnimationDriver, MockAnimationPlayer} from '@angular/platform-browser/animations/testing';
import {getDOM} from '@angular/platform-browser/src/dom/dom_adapter';

import {TestBed} from '../../testing';
Expand Down
1 change: 0 additions & 1 deletion packages/examples/_common/system-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ System.config({
'@angular/common': '/vendor/@angular/common/bundles/common.umd.js',
'@angular/compiler': '/vendor/@angular/compiler/bundles/compiler.umd.js',
'@angular/animations': '/vendor/@angular/animations/bundles/animations.umd.js',
'@angular/animations/browser': '/vendor/@angular/animations/bundles/animations-browser.umd.js',
'@angular/platform-browser/animations':
'/vendor/@angular/platform-browser/bundles/platform-browser-animations.umd.js',
'@angular/core': '/vendor/@angular/core/bundles/core.umd.js',
Expand Down
3 changes: 1 addition & 2 deletions packages/examples/core/animation/ts/dsl/animation_example.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@
*/

// #docregion Component
import {animate, state, style, transition, trigger} from '@angular/animations';
import {Component, NgModule} from '@angular/core';
import {Component, NgModule, animate, state, style, transition, trigger} from '@angular/core';
import {BrowserAnimationsModule} from '@angular/platform-browser/animations';

@Component({
Expand Down
1 change: 1 addition & 0 deletions packages/platform-browser/animations/src/animations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@
* Entry point for all animation APIs of the animation browser package.
*/
export {BrowserAnimationsModule, NoopAnimationsModule} from './module';
export {AnimationDriver} from './render/animation_driver';
export * from './private_export';
2 changes: 1 addition & 1 deletion packages/platform-browser/animations/src/module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.io/license
*/
import {NgModule} from '@angular/core';
import {BrowserModule} from '@angular/platform-browser';
import {BrowserModule, ɵDomRendererFactory2} from '@angular/platform-browser';

import {BROWSER_ANIMATIONS_PROVIDERS, BROWSER_NOOP_ANIMATIONS_PROVIDERS} from './providers';

Expand Down
7 changes: 6 additions & 1 deletion packages/platform-browser/animations/src/private_export.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,9 @@
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license
*/
export {AnimationRenderer as ɵAnimationRenderer, AnimationRendererFactory as ɵAnimationRendererFactory} from './animation_renderer';
export {AnimationEngine as ɵAnimationEngine} from './animation_engine';
export {Animation as ɵAnimation} from './dsl/animation';
export {AnimationStyleNormalizer as ɵAnimationStyleNormalizer, NoopAnimationStyleNormalizer as ɵNoopAnimationStyleNormalizer} from './dsl/style_normalization/animation_style_normalizer';
export {NoopAnimationDriver as ɵNoopAnimationDriver} from './render/animation_driver';
export {AnimationRenderer as ɵAnimationRenderer, AnimationRendererFactory as ɵAnimationRendererFactory} from './render/animation_renderer';
export {DomAnimationEngine as ɵDomAnimationEngine} from './render/dom_animation_engine';
12 changes: 9 additions & 3 deletions packages/platform-browser/animations/src/providers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,17 @@
* found in the LICENSE file at https://angular.io/license
*/

import {AnimationDriver, ɵAnimationEngine as AnimationEngine, ɵAnimationStyleNormalizer as AnimationStyleNormalizer, ɵDomAnimationEngine as DomAnimationEngine, ɵNoopAnimationDriver as NoopAnimationDriver, ɵNoopAnimationEngine as NoopAnimationEngine, ɵWebAnimationsDriver as WebAnimationsDriver, ɵWebAnimationsStyleNormalizer as WebAnimationsStyleNormalizer, ɵsupportsWebAnimations as supportsWebAnimations} from '@angular/animations/browser';
import {Injectable, NgZone, Provider, RendererFactory2} from '@angular/core';
import {ɵDomRendererFactory2} from '@angular/platform-browser';

import {AnimationRendererFactory} from './animation_renderer';
import {AnimationEngine} from './animation_engine';
import {AnimationStyleNormalizer} from './dsl/style_normalization/animation_style_normalizer';
import {WebAnimationsStyleNormalizer} from './dsl/style_normalization/web_animations_style_normalizer';
import {AnimationDriver, NoopAnimationDriver} from './render/animation_driver';
import {AnimationRendererFactory} from './render/animation_renderer';
import {DomAnimationEngine} from './render/dom_animation_engine';
import {NoopAnimationEngine} from './render/noop_animation_engine';
import {WebAnimationsDriver, supportsWebAnimations} from './render/web_animations/web_animations_driver';

@Injectable()
export class InjectableAnimationEngine extends DomAnimationEngine {
Expand Down Expand Up @@ -59,4 +65,4 @@ export const BROWSER_NOOP_ANIMATIONS_PROVIDERS: Provider[] = [
useFactory: instantiateRendererFactory,
deps: [ɵDomRendererFactory2, AnimationEngine, NgZone]
}
];
];
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,11 @@
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license
*/
import {AnimationTriggerMetadata} from '@angular/animations';
import {ɵAnimationEngine as AnimationEngine} from '@angular/animations/browser';
import {AnimationEvent, AnimationTriggerMetadata} from '@angular/animations';
import {Injectable, NgZone, Renderer2, RendererFactory2, RendererStyleFlags2, RendererType2} from '@angular/core';

import {AnimationEngine} from '../animation_engine';

@Injectable()
export class AnimationRendererFactory implements RendererFactory2 {
constructor(
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@
* found in the LICENSE file at https://angular.io/license
*/
import {AnimationEvent, NoopAnimationPlayer, animate, keyframes, state, style, transition, trigger} from '@angular/animations';
import {el} from '@angular/platform-browser/testing/browser_util';
import {el} from '@angular/platform-browser/testing/src/browser_util';

import {buildAnimationKeyframes} from '../../src/dsl/animation_timeline_visitor';
import {buildTrigger} from '../../src/dsl/animation_trigger';
import {AnimationStyleNormalizer, NoopAnimationStyleNormalizer} from '../../src/dsl/style_normalization/animation_style_normalizer';
import {DomAnimationEngine} from '../../src/render/dom_animation_engine';
import {MockAnimationDriver, MockAnimationPlayer} from '../../testing/mock_animation_driver';
import {MockAnimationDriver, MockAnimationPlayer} from '../../testing/src/mock_animation_driver';

function makeTrigger(name: string, steps: any) {
const triggerData = trigger(name, steps);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@
* found in the LICENSE file at https://angular.io/license
*/
import {state, style, trigger} from '@angular/animations';
import {ɵNoopAnimationEngine as NoopAnimationEngine} from '@angular/animations/browser';
import {el} from '@angular/platform-browser/testing/browser_util';
import {el} from '@angular/platform-browser/testing/src/browser_util';

import {NoopAnimationEngine} from '../src/render/noop_animation_engine';

export function main() {
describe('NoopAnimationEngine', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,20 @@
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license
*/
import {animate, style, transition, trigger} from '@angular/animations';
import {ɵAnimationEngine, ɵNoopAnimationEngine} from '@angular/animations/browser';
import {animate, state, style, transition, trigger} from '@angular/animations';
import {Component} from '@angular/core';
import {TestBed} from '@angular/core/testing';

import {ɵAnimationEngine} from '@angular/platform-browser/animations';
import {NoopAnimationsModule} from '../src/module';
import {NoopAnimationEngine} from '../src/render/noop_animation_engine';

export function main() {
describe('NoopAnimationsModule', () => {
beforeEach(() => { TestBed.configureTestingModule({imports: [NoopAnimationsModule]}); });

it('the engine should be a Noop engine', () => {
const engine = TestBed.get(ɵAnimationEngine);
expect(engine instanceof ɵNoopAnimationEngine).toBeTruthy();
expect(engine instanceof NoopAnimationEngine).toBeTruthy();
});

it('should flush and fire callbacks when the zone becomes stable', (async) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/
import {AUTO_STYLE, AnimationPlayer, NoopAnimationPlayer, ɵStyleData} from '@angular/animations';

import {AnimationDriver} from '../src/render/animation_driver';
import {AnimationDriver} from '../../src/render/animation_driver';

/**
* @experimental Animation support is experimental.
Expand Down
24 changes: 24 additions & 0 deletions packages/platform-browser/animations/testing/tsconfig-build.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"extends": "../../tsconfig-build",
"compilerOptions": {
"outDir": "../../../../dist/packages/platform-browser",
"paths": {
"@angular/core": ["../../dist/packages/core"],
"@angular/core/testing": ["../../dist/packages/core/testing"],
"@angular/animations": ["../../dist/packages/animations"],
"@angular/platform-browser": ["../../dist/packages/platform-browser"],
"@angular/platform-browser/animations": ["../../dist/packages/platform-browser/animations"],
"@angular/common": ["../../dist/packages/common"],
"@angular/common/testing": ["../../dist/packages/common/testing"]
}
},
"files": [
"index.ts",
"../../../../node_modules/@types/hammerjs/index.d.ts",
"../../../../node_modules/@types/jasmine/index.d.ts",
"../../../../node_modules/zone.js/dist/zone.js.d.ts"
],
"angularCompilerOptions": {
"strictMetadataEmit": true
}
}
17 changes: 8 additions & 9 deletions packages/platform-browser/animations/tsconfig-build.json
Original file line number Diff line number Diff line change
@@ -1,19 +1,18 @@
{
"extends": "./tsconfig-build",
"extends": "../tsconfig-build",

"compilerOptions": {
"outDir": "../../../dist/packages-dist/platform-browser",
"outDir": "../../../dist/packages/platform-browser",
"paths": {
"rxjs/*": ["../../../node_modules/rxjs/*"],
"@angular/core": ["../../../dist/packages-dist/core"],
"@angular/core/testing": ["../../../dist/packages-dist/core/testing"],
"@angular/animations": ["../../../dist/packages-dist/animations"],
"@angular/animations/browser": ["../../../dist/packages-dist/animations/browser"],
"@angular/platform-browser": ["../../../dist/packages-dist/platform-browser"]
"rxjs/*": ["../../node_modules/rxjs/*"],
"@angular/core": ["../../dist/packages/core"],
"@angular/core/testing": ["../../dist/packages/core/testing"],
"@angular/animations": ["../../dist/packages/animations"],
"@angular/platform-browser": ["../../dist/packages/platform-browser"]
}
},
"files": [
"animations/public_api.ts",
"public_api.ts",
"../../../node_modules/zone.js/dist/zone.js.d.ts",
"../../system.d.ts"
],
Expand Down
Loading

0 comments on commit e6c81d2

Please sign in to comment.