Expand environment variables in config files.

[lewis6991]

In .luarc.json I have:

  "workspace": {
    "library": [
      "lua",
      "$VIMRUNTIME",
      "nvim-test",
      "${3rd}/busted/library",
      "${3rd}/luassert/library",
      "${3rd}/luv/library"
    ],
    "checkThirdParty": false
  },

I know ${3rd} probably won't be supported here, but could other environment variables be expanded?

[CppCXY]

In .luarc.json I have:

"workspace": {
"library": [
"lua",
"$VIMRUNTIME",
"nvim-test",
"${3rd}/busted/library",
"${3rd}/luassert/library",
"${3rd}/luv/library"
],
"checkThirdParty": false
},
I know ${3rd} probably won't be supported here, but could other environment variables be expanded?

I can support anything, but I remember that the format for luals' env is {env:xxx}.

[lewis6991]

How do you mean? The .luarc.json snippet above works in LuaLS.

[CppCXY]

https://github.com/LuaLS/lua-language-server/blob/06943cfabb3c8957a15c28ffc0ac7fbc18dfd8f7/script/files.lua#L945

I see here

[lewis6991]

Environment variables are also expanded here: https://github.com/LuaLS/lua-language-server/blob/06943cfabb3c8957a15c28ffc0ac7fbc18dfd8f7/script/files.lua#L958 and https://github.com/LuaLS/lua-language-server/blob/06943cfabb3c8957a15c28ffc0ac7fbc18dfd8f7/script/utility.lua#L719

[CppCXY]

Environment variables are also expanded here: https://github.com/LuaLS/lua-language-server/blob/06943cfabb3c8957a15c28ffc0ac7fbc18dfd8f7/script/files.lua#L958 and https://github.com/LuaLS/lua-language-server/blob/06943cfabb3c8957a15c28ffc0ac7fbc18dfd8f7/script/utility.lua#L719

ok，I'll take another look when I'm at work.

[CppCXY]

see: 7ce383f

[lewis6991]

I've just updated to 0.4.6 and this still doesn't seem to work.

[CppCXY]

Okay, I'll check it.

[CppCXY]

I will generate the log file in the log directory of the executable. Can you send it over for me to take a look?

[lewis6991]

[2025-02-07 11:58:49 +00:00 INFO emmylua_ls::logger] emmylua_ls v0.4.6
[2025-02-07 11:58:49 +00:00 INFO emmylua_ls::handlers::initialized] client_id: Neovim
[2025-02-07 11:58:49 +00:00 INFO emmylua_ls::handlers::initialized] initialization_params: {
  "processId": 74913,
  "rootPath": "/Users/lewrus01/projects/gitsigns.nvim",
  "rootUri": "file:///Users/lewrus01/projects/gitsigns.nvim",
  "capabilities": {
    "workspace": {
      "applyEdit": true,
      "workspaceEdit": {
        "resourceOperations": [
          "rename",
          "create",
          "delete"
        ]
      },
      "didChangeConfiguration": {
        "dynamicRegistration": false
      },
      "didChangeWatchedFiles": {
        "dynamicRegistration": true,
        "relativePatternSupport": true
      },
      "symbol": {
        "dynamicRegistration": false,
        "symbolKind": {
          "valueSet": [
            1,
            2,
            3,
            4,
            5,
            6,
            7,
            8,
            9,
            10,
            11,
            12,
            13,
            14,
            15,
            16,
            17,
            18,
            19,
            20,
            21,
            22,
            23,
            24,
            25,
            26
          ]
        }
      },
      "workspaceFolders": true,
      "configuration": true,
      "semanticTokens": {
        "refreshSupport": true
      },
      "inlayHint": {
        "refreshSupport": true
      }
    },
    "textDocument": {
      "synchronization": {
        "dynamicRegistration": false,
        "willSave": true,
        "willSaveWaitUntil": true,
        "didSave": true
      },
      "completion": {
        "dynamicRegistration": false,
        "completionItem": {
          "snippetSupport": true,
          "commitCharactersSupport": false,
          "documentationFormat": [
            "markdown",
            "plaintext"
          ],
          "deprecatedSupport": true,
          "preselectSupport": false,
          "tagSupport": {
            "valueSet": [
              1
            ]
          },
          "resolveSupport": {
            "properties": [
              "additionalTextEdits"
            ]
          }
        },
        "completionItemKind": {
          "valueSet": [
            1,
            2,
            3,
            4,
            5,
            6,
            7,
            8,
            9,
            10,
            11,
            12,
            13,
            14,
            15,
            16,
            17,
            18,
            19,
            20,
            21,
            22,
            23,
            24,
            25
          ]
        },
        "contextSupport": false,
        "completionList": {
          "itemDefaults": [
            "editRange",
            "insertTextFormat",
            "insertTextMode",
            "data"
          ]
        }
      },
      "hover": {
        "dynamicRegistration": true,
        "contentFormat": [
          "markdown",
          "plaintext"
        ]
      },
      "signatureHelp": {
        "dynamicRegistration": false,
        "signatureInformation": {
          "documentationFormat": [
            "markdown",
            "plaintext"
          ],
          "parameterInformation": {
            "labelOffsetSupport": true
          },
          "activeParameterSupport": true
        }
      },
      "references": {
        "dynamicRegistration": false
      },
      "documentHighlight": {
        "dynamicRegistration": false
      },
      "documentSymbol": {
        "dynamicRegistration": false,
        "symbolKind": {
          "valueSet": [
            1,
            2,
            3,
            4,
            5,
            6,
            7,
            8,
            9,
            10,
            11,
            12,
            13,
            14,
            15,
            16,
            17,
            18,
            19,
            20,
            21,
            22,
            23,
            24,
            25,
            26
          ]
        },
        "hierarchicalDocumentSymbolSupport": true
      },
      "formatting": {
        "dynamicRegistration": true
      },
      "rangeFormatting": {
        "dynamicRegistration": true
      },
      "declaration": {
        "linkSupport": true
      },
      "definition": {
        "dynamicRegistration": true,
        "linkSupport": true
      },
      "typeDefinition": {
        "linkSupport": true
      },
      "implementation": {
        "linkSupport": true
      },
      "codeAction": {
        "dynamicRegistration": true,
        "codeActionLiteralSupport": {
          "codeActionKind": {
            "valueSet": [
              "",
              "quickfix",
              "refactor",
              "refactor.extract",
              "refactor.inline",
              "refactor.rewrite",
              "source",
              "source.organizeImports"
            ]
          }
        },
        "isPreferredSupport": true,
        "dataSupport": true,
        "resolveSupport": {
          "properties": [
            "edit"
          ]
        }
      },
      "codeLens": {
        "dynamicRegistration": false
      },
      "rename": {
        "dynamicRegistration": true,
        "prepareSupport": true
      },
      "publishDiagnostics": {
        "relatedInformation": true,
        "tagSupport": {
          "valueSet": [
            1,
            2
          ]
        },
        "dataSupport": true
      },
      "foldingRange": {
        "dynamicRegistration": false,
        "lineFoldingOnly": true,
        "foldingRange": {
          "collapsedText": true
        }
      },
      "callHierarchy": {
        "dynamicRegistration": false
      },
      "semanticTokens": {
        "dynamicRegistration": false,
        "requests": {
          "range": false,
          "full": {
            "delta": true
          }
        },
        "tokenTypes": [
          "namespace",
          "type",
          "class",
          "enum",
          "interface",
          "struct",
          "typeParameter",
          "parameter",
          "variable",
          "property",
          "enumMember",
          "event",
          "function",
          "method",
          "macro",
          "keyword",
          "modifier",
          "comment",
          "string",
          "number",
          "regexp",
          "operator",
          "decorator"
        ],
        "tokenModifiers": [
          "declaration",
          "definition",
          "readonly",
          "static",
          "deprecated",
          "abstract",
          "async",
          "modification",
          "documentation",
          "defaultLibrary"
        ],
        "formats": [
          "relative"
        ],
        "overlappingTokenSupport": true,
        "multilineTokenSupport": false,
        "serverCancelSupport": false,
        "augmentsSyntaxTokens": true
      },
      "inlayHint": {
        "dynamicRegistration": true,
        "resolveSupport": {
          "properties": [
            "textEdits",
            "tooltip",
            "location",
            "command"
          ]
        }
      },
      "diagnostic": {
        "dynamicRegistration": false
      }
    },
    "window": {
      "workDoneProgress": true,
      "showMessage": {
        "messageActionItem": {
          "additionalPropertiesSupport": true
        }
      },
      "showDocument": {
        "support": true
      }
    },
    "general": {
      "positionEncodings": [
        "utf-8",
        "utf-16",
        "utf-32"
      ]
    }
  },
  "trace": "off",
  "workspaceFolders": [
    {
      "uri": "file:///Users/lewrus01/projects/gitsigns.nvim",
      "name": "/Users/lewrus01/projects/gitsigns.nvim"
    }
  ],
  "clientInfo": {
    "name": "Neovim",
    "version": "0.11.0-dev+ge4a58a7ca0"
  },
  "workDoneToken": "1"
}
[2025-02-07 11:58:49 +00:00 INFO emmylua_ls::context::config_manager] load config from: "/Users/lewrus01/projects/gitsigns.nvim/.luarc.json"
[2025-02-07 11:58:49 +00:00 INFO emmylua_code_analysis::db_index::module] update module pattern: [Regex("^(.*)/init\\.lua$"), Regex("^(.*)\\.lua$")]
[2025-02-07 11:58:49 +00:00 INFO emmylua_code_analysis::db_index::module] update module replace pattern: []
[2025-02-07 11:58:49 +00:00 INFO emmylua_ls::handlers::initialized] current config : {
  "$schema": "https://raw.githubusercontent.com/LuaLS/vscode-lua/master/setting/schema.json",
  "completion": {
    "enable": true,
    "autoRequire": true,
    "autoRequireFunction": "require",
    "autoRequireNamingConvention": "keep",
    "callSnippet": false,
    "postfix": "@"
  },
  "diagnostics": {
    "disable": [],
    "enable": true,
    "globals": [],
    "globalsRegex": [],
    "severity": {},
    "enables": [],
    "diagnosticInterval": null
  },
  "signature": {
    "detailSignatureHelper": true
  },
  "hint": {
    "enable": true,
    "paramHint": true,
    "indexHint": true,
    "localHint": true,
    "overrideHint": true
  },
  "runtime": {
    "version": "LuaJIT",
    "requireLikeFunction": [],
    "frameworkVersions": [],
    "extensions": [],
    "requirePattern": []
  },
  "workspace": {
    "ignoreDir": [],
    "ignoreGlobs": [],
    "library": [
      "/Users/lewrus01/projects/gitsigns.nvim/lua",
      "/Users/lewrus01/projects/gitsigns.nvim//usr/local/share/nvim/runtime",
      "/Users/lewrus01/projects/gitsigns.nvim/nvim-test",
      "/Users/lewrus01/projects/gitsigns.nvim/{3rd}/busted/library",
      "/Users/lewrus01/projects/gitsigns.nvim/{3rd}/luassert/library",
      "/Users/lewrus01/projects/gitsigns.nvim/{3rd}/luv/library"
    ],
    "workspaceRoots": [],
    "preloadFileSize": 0,
    "encoding": "utf-8",
    "moduleMap": []
  },
  "resource": {
    "paths": []
  },
  "codeLens": {
    "enable": true
  },
  "strict": {
    "requirePath": true,
    "typeCall": false
  },
  "semanticTokens": {
    "enable": true
  },
  "references": {
    "enable": true,
    "fuzzySearch": true
  },
  "hover": {
    "enable": true
  },
  "documentColor": {
    "enable": true
  }
}
[2025-02-07 11:58:49 +00:00 INFO emmylua_ls::handlers::initialized] add workspace root: "/Users/lewrus01/projects/gitsigns.nvim"
[2025-02-07 11:58:49 +00:00 INFO emmylua_ls::handlers::initialized] add library: "/Users/lewrus01/projects/gitsigns.nvim/lua"
[2025-02-07 11:58:49 +00:00 INFO emmylua_ls::handlers::initialized] add library: "/Users/lewrus01/projects/gitsigns.nvim//usr/local/share/nvim/runtime"
[2025-02-07 11:58:49 +00:00 INFO emmylua_ls::handlers::initialized] add library: "/Users/lewrus01/projects/gitsigns.nvim/nvim-test"
[2025-02-07 11:58:49 +00:00 INFO emmylua_ls::handlers::initialized] add library: "/Users/lewrus01/projects/gitsigns.nvim/{3rd}/busted/library"
[2025-02-07 11:58:49 +00:00 INFO emmylua_ls::handlers::initialized] add library: "/Users/lewrus01/projects/gitsigns.nvim/{3rd}/luassert/library"
[2025-02-07 11:58:49 +00:00 INFO emmylua_ls::handlers::initialized] add library: "/Users/lewrus01/projects/gitsigns.nvim/{3rd}/luv/library"
[2025-02-07 11:58:49 +00:00 INFO emmylua_ls::handlers::initialized::collect_files] collect_files from: ["/Users/lewrus01/projects/gitsigns.nvim", "/Users/lewrus01/projects/gitsigns.nvim/lua", "/Users/lewrus01/projects/gitsigns.nvim//usr/local/share/nvim/runtime", "/Users/lewrus01/projects/gitsigns.nvim/nvim-test", "/Users/lewrus01/projects/gitsigns.nvim/{3rd}/busted/library", "/Users/lewrus01/projects/gitsigns.nvim/{3rd}/luassert/library", "/Users/lewrus01/projects/gitsigns.nvim/{3rd}/luv/library"] match_pattern: ["**/*.lua"] exclude: [], exclude_dir: []
[2025-02-07 11:58:50 +00:00 ERROR emmylua_code_analysis::vfs::loader] Error decoding file: "/Users/lewrus01/projects/gitsigns.nvim/lua-language-server-3.13.6-Darwin-arm64/meta/3rd/Defold/library/luasocket.lua"
[2025-02-07 11:58:54 +00:00 INFO emmylua_ls::handlers::initialized::collect_files] load files from workspace count: 1282
[2025-02-07 11:58:54 +00:00 INFO emmylua_code_analysis::profile] update files: cost 329.495875ms
[2025-02-07 11:58:54 +00:00 INFO emmylua_code_analysis::profile] module analyze: cost 4.157042ms
[2025-02-07 11:58:54 +00:00 INFO emmylua_code_analysis::profile] decl analyze: cost 339.104291ms
[2025-02-07 11:58:54 +00:00 INFO emmylua_code_analysis::profile] flow analyze: cost 51.345291ms
[2025-02-07 11:58:55 +00:00 INFO emmylua_code_analysis::profile] doc analyze: cost 228.778458ms
[2025-02-07 11:58:55 +00:00 INFO emmylua_code_analysis::profile] lua analyze: cost 149.886583ms
[2025-02-07 11:58:55 +00:00 INFO emmylua_code_analysis::profile] resolve analyze: cost 58.506917ms
[2025-02-07 11:58:55 +00:00 INFO emmylua_code_analysis::profile] diagnose 1236 files: cost 146.868125ms

I can see the problem "/Users/lewrus01/projects/gitsigns.nvim//usr/local/share/nvim/runtime",. Path needs to be absolute and not relative to cwd.

[CppCXY]

and I found

[2025-02-07 11:58:50 +00:00 ERROR emmylua_code_analysis::vfs::loader] Error decoding file: "/Users/lewrus01/projects/gitsigns.nvim/lua-language-server-3.13.6-Darwin-arm64/meta/3rd/Defold/library/luasocket.lua"

It seems there is an encoding issue.

[lewis6991]

I don't actually need that library. Seems like an additional issue?