Refactor post_updated and wp_insert_post callbacks #204
+53
−61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR solves the issue we have described in #122 .
While testing after refactoring I found a bug, the refactored method was working fine but the problem was in transition_post_status method which allowed multiple
update
activities to be added.I believe that was wrong since in the
post_updated
method we had a check for not addingupdate
activity if it was already added recently.transition_post_status
was missing that check so it allowed user to add activities by simply changing the post status, for example frompublish
todraft
and back fromdraft
topublish
.If I was wrong then only the 2nd commit needs to be reverted.
Quality assurance
Fixes #122