Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype 3rd party plugin suggested tasks #150

Draft
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

ilicfilip
Copy link
Collaborator

No description provided.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Test on Playground
Test this pull request on the Playground or download the zip.

@aristath
Copy link
Member

aristath commented Dec 9, 2024

PR needs rebasing

@aristath
Copy link
Member

@ilicfilip Is it my impression, or is there something missing here?

@aristath aristath marked this pull request as draft December 11, 2024 07:27
@ilicfilip
Copy link
Collaborator Author

Must be that some merge removed the code, I have put it back now.

There are 2 examples:

  • Integration with Yoast SEO plugin, to set Organization logo (this is what I started with)
  • A new WP Core task, to set blog description field if it is empty (this is what I added as an example after the refactor, which was split to different PR)

There is one open question:
Pending tasks are added to the progress_planner_local_tasks option, they wont be displayed to the user if the plugin is deactivated but they will stay there which might cause the clutter down the road.
Do we remove them if plugin is deactivated or leave as is?

@aristath
Copy link
Member

Do we remove them if plugin is deactivated or leave as is?

Remove them using the uninstall.php file implementation 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants