CS: load script in a non-page-render-blocking manner #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
By loading scripts in the footer of a page, the page rendering is not blocked by the script download. Includes minor code layout reformatting for readability.
abotteram
force-pushed
the
JRF/CSQA/script-loading-in-footer
branch
from
e9148ee to
5f8bd02
Compare
|
CR 👍 |
abotteram
force-pushed
the
JRF/CSQA/script-loading-in-footer
branch
from
342b068 to
5f8bd02
Compare
karlijnbok
added
the
changelog: non-user-facing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By loading scripts in the footer of a page, the page rendering is not blocked by the script download.
Includes minor code layout reformatting for readability.
Technical
grunt shell:phpcsoverride. Travis failed when callingvendor/squizlabs/php_codesniffer/scripts/phpcs(defined in@yoast/plugin-grunt-tasks) but in this version of php_codesniffer it is located invendor/squizlabs/php_codesniffer/bin/phpcs.Testing
Highly recommended!