Added Event to fill Inventorys <item> <inv> <ec> etc. #31
Conversation
SaltyAlpaca
commented
Apr 19, 2025
SaltyAlpaca
commented
Added Support for a custom Inventory filler, mostly for Enderchest, but also working for Inventory and Item
Reorderd the Inventory, to have a way better look and nicer view of the GUI with the armors being now at the top and the hotbar at the bottom fixing an ugly appearence and better code structure
This event replaces the CustomInventoryAPI with a simple Event
updated the ordering of the Armor and Items in the Inventory Share GUI
Fixed an Issue with the Item Display
Emibergo02
left a comment
Emibergo02
left a comment
There was a problem hiding this comment.
Looks good after the reviewed parts are fixed. I will make some optimizations and syntax corrections on for int loops and then it will be merged
| Bukkit.getPluginManager().callEvent(itemEvent); | ||
|
|
||
| // 3) Unwrap result | ||
| ItemStack[] itemArr = itemEvent.getContents(); |
There was a problem hiding this comment.
I would clone the item array here instead of the Event setContent method
There was a problem hiding this comment.
wdym, just clone it? Like this:
ItemStack[] originalArr = itemEvent.getContents();
ItemStack[] clonedArr = Arrays.stream(originalArr)
.map(item -> item == null ? null : item.clone())
.toArray(ItemStack[]::new);
ItemStack itemToDisplay = (clonedArr.length > 0 && clonedArr[0] != null)
? clonedArr[0]
: new ItemStack(Material.AIR);
| .getPlayerItem(targetName) | ||
| .thenAccept(item -> { | ||
| ItemStack[] guiItems = new ItemStack[27]; | ||
| Arrays.fill(guiItems, new ItemStack(Material.AIR)); |
There was a problem hiding this comment.
I think this is not necessary. nulls are taken as material air anyway
There was a problem hiding this comment.
i don't know, i just did it to be sure
| } | ||
| }.runTaskLater(plugin, 1))).open(player); | ||
| } | ||
| // Inhalte auf die GUI‑Größe trimmen/padden |
|
|
||
| this.executorService = Executors.newFixedThreadPool(config.chatThreads); | ||
|
|
||
|
|
|
|
||
| public InventoryPlaceholderEvent(Player player, Type type, ItemStack[] defaultContents) { | ||
| super(!player.getServer().isPrimaryThread()); | ||
| this.player = player; |
There was a problem hiding this comment.
mmh please stick with the normal spaces conventions
|
|
||
| @AllArgsConstructor | ||
| public class ComponentProvider { | ||
| @Subst("") |
There was a problem hiding this comment.
Stop it. remove this Subst please
There was a problem hiding this comment.
i couldn't remember where i put it 😭
|
i could do it tomorrow maybe |
idk what i should write here
Happy?
2 participants
