feat(ink): expand test coverage + fix ToolCallView controlled component#21
Merged
EmersonBraun merged 5 commits intomainfrom Apr 5, 2026
Merged
feat(ink): expand test coverage + fix ToolCallView controlled component#21EmersonBraun merged 5 commits intomainfrom
EmersonBraun merged 5 commits intomainfrom
Conversation
BREAKING: Removed internal useInput handler that toggled all instances simultaneously when pressing 't'. ToolCallView now accepts an optional `expanded` prop — the parent controls which tool call is expanded.
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #4 — expands
@agentskit/inktest coverage from 1 smoke test to 19 tests.ToolCallViewconverted to controlled component withexpandedprop. Previously all instances toggled simultaneously when pressingt(globaluseInputbug).expanded, error display, status variantsTest plan