UI updates #54
Merged
UI updates #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Its not yet ready, i could do another round of clean up and add namespacing to agentE UI styling. |
teaxio
reviewed
Jun 21, 2024
ae/core/playwright_manager.py
Outdated
|
|
||
| safe_message_type = escape_js_message(message_type) | ||
| if self.ui_manager.overlay_show_details == False: | ||
| if not (message_type == "plan" or message_type == "question" or message_type == "answer" or message_type == "info"): |
There was a problem hiding this comment.
This would look cleaner as:
if message_type not in {"plan", "question", "answer", "info"}:
ae/core/playwright_manager.py
Outdated
| return | ||
|
|
||
| if self.ui_manager.overlay_show_details == True: | ||
| if not (message_type == "plan" or message_type == "question" or message_type == "answer" or message_type == "info" or message_type == "step"): |
There was a problem hiding this comment.
Cleaner as:
if message_type not in {"plan", "question", "answer", "info", "step"}:
ae/core/playwright_manager.py
Outdated
| page = await self.get_current_page() | ||
| await page.evaluate(js_code) | ||
| logger.debug("User notification completed") | ||
| except Exception as e: | ||
| print(f"Failed to notify user with message \"{message}\". However, most likey this will work itself out after the page loads: {e}") |
There was a problem hiding this comment.
We can just change the logger line below it to be logger.error (logger.warn) right? This way we have one print
| Update the processing state of the overlay. | ||
|
|
||
| Args: | ||
| is_processing (str): "init", "processing", "done" |
There was a problem hiding this comment.
this would be best put in an enum. But we can fix that at some point, maybe just a #TODO: as reminder to address this?
added 11 commits
July 2, 2024 13:37
teaxio
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.