[FEATURE] cherry-pick json parsing changes #486
Merged
+466
−163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EllingtonKirby
changed the title
m-naumann
reviewed
Jul 5, 2025
| } | ||
| } | ||
|
|
||
| void from_dom(const simdjson::dom::element &j, TrafficLightState &tl_state) |
Collaborator
There was a problem hiding this comment.
Hi @EllingtonKirby @daphne-cornelisse, I get
#17 83.90 /gpudrive/src/json_serialization.hpp:134:52: error: unknown type name 'TrafficLightState'
#17 83.93 134 | void from_dom(const simdjson::dom::element &j, TrafficLightState &tl_state)
I guess because #485 is not yet merged.
m-naumann
added a commit
to m-naumann/gpudrive
that referenced
this pull request
Jul 7, 2025
daphne-cornelisse
pushed a commit
that referenced
this pull request
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #485
Cherry picks the minimal changes needed to integrate the JSON parsing upgrade into main