add seed executable #881
Merged
add seed executable #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaroslavLitvinov
force-pushed
the
issues/808_v2_embucket_seed
branch
from
d2826fc to
784cf13
Compare
YaroslavLitvinov
force-pushed
the
issues/808_v2_embucket_seed
branch
2 times, most recently
from
bc4f719 to
2893a43
Compare
rampage644
reviewed
May 26, 2025
YaroslavLitvinov
force-pushed
the
issues/808_v2_embucket_seed
branch
from
ef81902 to
4d9a914
Compare
rampage644
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #808
This PR was added instead of blocked and now closed PR #841
It is based on features added in PR #841, addressing concerns raised on PR review:
api-structscrate left in old PR and didn't move hereembucket-seedexecutable.api-structs,api-client-rest,api-seedavailable anymore, instead got a single crateembucket-seed.Dependencies
Below illustrated dependencies for both old PR - v1 , new PR - v2
which means v2 now has dependencies on monolithic crates
v1 PR BLOCKED Issues/808 seed demo data on server startup #841
[dependencies]
api-client-rest = { path = "../api-client-rest" }
api-structs = { path = "../api-structs", features = ["serde", "partial", "eq"] }
...
v2
[dependencies]
core-metastore = { path = "../core-metastore" }
api-ui = { path = "../api-ui", features = ["client"] }
...