Skip to content

separated positional parameters functionality in tests #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

andheroe
Copy link
Contributor

  1. Tests for Pivot, Values, and Result_Scan were using positional parameters functionality ($). Now they don't use it.
  2. There is a separate .slt that extensively tests positional parameters functionality.
  3. There is a separate file that extensively tests aliases functionality - because of the recently found issue.

…nto it's own file, also create a test file for aliases
Copy link
Contributor

SQL Logic Tests Results ❌

Coverage by SLT File

  • pivot: 8/13 (61.5%)
  • values: 4/5 (80.0%)
  • aliases: 17/27 (63.0%)
  • positional_parameters: 0/24 (0.0%)

Overall: 29/69 (42.0%)

@andheroe andheroe merged commit a6bc537 into main Jun 16, 2025
3 checks passed
@andheroe andheroe deleted the feature/granular-positional-parameter-tests branch June 16, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants