Skip to content

Add datetime with precission support #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 16, 2025
Merged

Conversation

osipovartem
Copy link
Contributor

Extended datetime type
Closes #1095
Related to #1093
https://docs.snowflake.com/en/sql-reference/data-types-datetime#datetime

DATETIME
DATETIME is an alias for TIMESTAMP_NTZ.

Copy link
Contributor

SQL Logic Tests Results ❌

Coverage by SLT File

  • timestampdiff: 0/3 (0.0%)
  • dateadd: 4/5 (80.0%)
  • date_trunc: 2/5 (40.0%)
  • timestampadd: 4/5 (80.0%)
  • to_timestamp: 0/10 (0.0%)
  • create-table: 23/40 (57.5%)
  • timestamp_from_parts: 3/6 (50.0%)
  • timeadd: 4/5 (80.0%)
  • extract: 1/1 (100.0%)
  • try_to_timestamp: 0/1 (0.0%)
  • trunc2: 0/4 (0.0%)

Overall: 41/85 (48.2%)

Base automatically changed from issues/1093_timestamp_datatypes to issues/1088_fix_timestamp_cast June 16, 2025 16:29
@osipovartem osipovartem force-pushed the issues/1095_datetime_type branch from 91ab654 to 307a785 Compare June 16, 2025 16:31
rampage644
rampage644 previously approved these changes Jun 16, 2025
Base automatically changed from issues/1088_fix_timestamp_cast to main June 16, 2025 16:52
@osipovartem osipovartem dismissed rampage644’s stale review June 16, 2025 16:52

The base branch was changed.

@osipovartem osipovartem force-pushed the issues/1095_datetime_type branch from 307a785 to 7898f1f Compare June 16, 2025 16:59
Copy link
Contributor

⚠️ The SLT test execution failed. Please check the workflow logs for details.

Copy link
Contributor

SQL Logic Tests Results ❌

Coverage by SLT File

  • to_timestamp: 0/10 (0.0%)
  • create-table: 23/40 (57.5%)
  • timestamp_from_parts: 3/6 (50.0%)
  • timestampadd: 4/5 (80.0%)
  • timestampdiff: 0/3 (0.0%)

Overall: 30/64 (46.9%)

@osipovartem osipovartem merged commit e5d3d1c into main Jun 16, 2025
6 checks passed
@osipovartem osipovartem deleted the issues/1095_datetime_type branch June 16, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DATETIME type support
2 participants