Skip to content

Cluster by expressions #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

Cluster by expressions #1096

merged 1 commit into from
Jun 13, 2025

Conversation

osipovartem
Copy link
Contributor

@osipovartem osipovartem commented Jun 13, 2025 •
edited
Loading

Fix for #1036

Also this allows to succsessufly run snowflow dbt seed and dbt run

based on Embucket/datafusion-sqlparser-rs#13

@github-actions GitHub Actions
Copy link
Contributor

SQL Logic Tests Results ❌

Coverage by SLT File

  • create-table: 23/40 (57.5%)
  • select: 19/20 (95.0%)
  • from: 2/2 (100.0%)
  • join: 3/11 (27.3%)
  • where: 6/10 (60.0%)
  • limit: 5/6 (83.3%)
  • order-by: 7/8 (87.5%)
  • group-by: 3/7 (42.9%)

Overall: 68/104 (65.4%)

DanCodedThis
DanCodedThis approved these changes Jun 13, 2025
View reviewed changes
Copy link
Contributor

@DanCodedThis DanCodedThis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@osipovartem LGTM

@osipovartem osipovartem merged commit 98cbc78 into main Jun 13, 2025
6 checks passed
@osipovartem osipovartem deleted the issues/1036_cluster_by_expr branch June 13, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravlio ravlio ravlio approved these changes

@DanCodedThis DanCodedThis DanCodedThis approved these changes

@rampage644 rampage644 Awaiting requested review from rampage644

@Vedin Vedin Awaiting requested review from Vedin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@osipovartem @ravlio @DanCodedThis