Skip to content

api: UI Query history for non-existent Worksheet #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

api: UI Query history for non-existent Worksheet #1086

merged 1 commit into from
Jun 12, 2025

Conversation

DanCodedThis
Copy link
Contributor

@DanCodedThis DanCodedThis commented Jun 12, 2025 •
edited
Loading

  • Checking if no worksheet exists
  • If not, only adding the query record to the global history
  • Tests for this already exist

@github-actions GitHub Actions
Copy link
Contributor

✅ SLT Targeted Testing: No relevant SLT tests found for the changes in this PR. No testing required.

@DanCodedThis
Copy link
Contributor Author

@YaroslavLitvinov We should probably change the return type of the .get_worksheet to Option<>, or to Result<Option<>>, no need to error if no worksheet found, it could simply be Ok(None) what do you think?

@DanCodedThis
Copy link
Contributor Author

DanCodedThis commented Jun 12, 2025 •
edited
Loading

This however will make pattern matching a bit more difficult, so maybe not a good idea

@YaroslavLitvinov
Copy link
Contributor

If wrong worksheet id is ignored there is no need returning error since query finally was executed. @nikitastryuk what do you think?

YaroslavLitvinov
YaroslavLitvinov approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@YaroslavLitvinov YaroslavLitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanCodedThis DanCodedThis merged commit a70e71f into main Jun 12, 2025
6 checks passed
@DanCodedThis DanCodedThis deleted the DanCodedThis/1085-non-existant-workseet-history branch June 12, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaroslavLitvinov YaroslavLitvinov YaroslavLitvinov approved these changes

@nikitastryuk nikitastryuk Awaiting requested review from nikitastryuk

@osipovartem osipovartem Awaiting requested review from osipovartem

@rampage644 rampage644 Awaiting requested review from rampage644

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanCodedThis @YaroslavLitvinov