Skip to content

Update upload step for integration test suite #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2025
Merged

Update upload step for integration test suite #1067

merged 2 commits into from
Jun 16, 2025

Conversation

rampage644
Copy link
Contributor

@rampage644 rampage644 commented Jun 11, 2025 •
edited
Loading

Summary

  • Replace requests-based HTTP API calls with direct Snowflake connector usage for schema creation
  • Add comprehensive environment variable configuration for Snowflake connection parameters
  • Include session parameters to tag queries for dbt testing context

Changes

  • Switch from HTTP API endpoint to snowflake.connector for database operations
  • Remove dependency on json module in favor of direct SQL execution
  • Add environment variables for flexible connection configuration (host, port, protocol, credentials, warehouse)
  • Include QUERY_TAG session parameter for better query tracking

Test plan

  • Verify environment variables are properly configured
  • Test schema creation with Snowflake connector
  • Confirm dbt integration tests still pass
  • Validate connection parameters work across different environments

🤖 Generated with Claude Code

@rampage644 @claude
Replace HTTP API calls with Snowflake connector in upload.py
0f95997 
- Switch from requests-based HTTP API to snowflake.connector for schema creation
- Add environment variable configuration for Snowflake connection parameters
- Include session parameters for dbt testing context
- Remove json import in favor of direct Snowflake connection

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@rampage644 rampage644 requested a review from osmazur June 11, 2025 22:33
@github-actions GitHub Actions
Copy link
Contributor

SQL Logic Tests Results ❌

Coverage by SLT File

  • create-table: 23/40 (57.5%)
  • set: 6/16 (37.5%)

Overall: 29/56 (51.8%)

@github-actions GitHub Actions
Copy link
Contributor

SQL Logic Tests Results ❌

Coverage by SLT File

  • create-table: 23/40 (57.5%)

Overall: 23/40 (57.5%)

@rampage644 rampage644 changed the title Replace HTTP API calls with Snowflake connector in upload.py Update upload step for integration test suite Jun 12, 2025
@rampage644 rampage644 merged commit 7b9d45b into main Jun 16, 2025
3 checks passed
@rampage644 rampage644 deleted the update-upload-py-snowflake-connector branch June 16, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andheroe andheroe andheroe approved these changes

@osmazur osmazur Awaiting requested review from osmazur

@YevheniiNiestierov YevheniiNiestierov Awaiting requested review from YevheniiNiestierov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rampage644 @andheroe