Skip to content

Add TOP clause support #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

Vedin
Copy link
Contributor

@Vedin Vedin commented Jun 11, 2025

Summary

  • rewrite TOP clauses into LIMIT via a visitor
  • apply the new visitor during SQL post-processing
  • add snapshot tests for TOP queries

Testing

  • cargo test -p core-executor --quiet (fails: heavy build, terminated)
  • python3 test/slt_runner_targeted.py test/sql/sql-reference-commands/Query_syntax/top_n.slt (fails: ModuleNotFoundError: No module named 'pandas')

https://chatgpt.com/codex/tasks/task_e_68416cb0f4348322ad51489716fd8c94

@Vedin Vedin added the codex label Jun 11, 2025 — with ChatGPT Connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant