fix: locate sentry-cli when working with a mono-repo
#19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current approach to locating the `sentry-cli` executable makes the assumption that the package is installed in an Ember app at the root of the repository. This works fine most of the time, but breaks in a mono-repo where the actual `node_modules` directory might be above the current project in the directory structure. This change dynamically locates the `sentry-cli` executable by: 1. Dynamically locating the `package.json` for the `@sentry/cli` package in a way that will work for both standard and mono-repo setups 2. Extracting the root of the `@sentry/cli` package from that path, which should be safe; the `package.json` will always be at the package root 3. Reading the `package.json` file for `@sentry/cli` to determine where the executable actually lives 4. Building an absolute path to the `sentry-cli` executable from the information that we've gathered This makes the approach to locating `sentry-cli` resilient to changes in the directory structure for different types of apps
alexlafroscia
force-pushed
the
better-sentry-cli-resolution
branch
from
0b8bd3f to
1789b10
Compare
|
This is awesome! Thank you Alex <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach to locating the
sentry-cliexecutable makes the assumption that the package is installed in an Ember app at the root of the repository. This works fine most of the time, but breaks in a mono-repo where the actualnode_modulesdirectory might be above the current project in the directory structure.This change dynamically locates the
sentry-cliexecutable by:package.jsonfor the@sentry/clipackage in a way that will work for both standard and mono-repo setups@sentry/clipackage from that path, which should be safe; thepackage.jsonwill always be at the package rootpackage.jsonfile for@sentry/clito determine where the executable actually livessentry-cliexecutable from the information that we've gatheredThis makes the approach to locating
sentry-cliresilient to changes in the directory structure for different types of apps