do not throw error when re-deploying same commit #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, some times on my CI/CD flow I deploy the same version (same commit) multiple times and sentry-cli seems to throw an error when we try to re-create a version with no commit changes. This flag ignores that and keeps sentry-cli from erroring allowing the deploy to continue.
Exelord
approved these changes
Jul 22, 2021
|
Thanks! We would need to adjust the tests :) |
|
hi @kevinkucharczyk I didn't have time to look at the tests, I have been using my fork in production, but I do not recomend you do that. Instead, if you have time, check with @Exelord what needs to be done wit the tests and make a new PR. |
|
Hey I just submitted a PR with the same functionality and passing tests (didn't see this PR). I don't care which PR gets merged, I would just like to have this functionality merged upstream and released. |
|
Done :) #18 merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, some times on my CI/CD flow I deploy the same version (same commit) multiple times and sentry-cli seems to throw an error when we try to re-create a version with no commit changes. This flag ignores that and keeps sentry-cli from erroring allowing the deploy to continue.