-
Notifications
You must be signed in to change notification settings - Fork 11
FEAT: do not throw error if previous release was not found #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: do not throw error if previous release was not found #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On your mark!😎
@Exelord |
5bfcd46
to
fa6162d
Compare
@Exelord I think I figured out what's going on here. Seems like the problem is about the order of passed flags vs actual release version. So if "set-commits --active --ignore-missing RELEASE_VERSION" flags are passed before the release version, the second argument (in our case I've moved the flags after the release version and now it seems to work as expected, also I've opened a new issue in the sentry-cli repo. I think it's still safe to go with the workaround of moving flags to after the release version, but before actually merging this I'd like some one else to test this version too 🙂 |
I think we are good :) |
Thanks, @Exelord 🎉🎉🎉 |
@Exelord hi, first of all thanks for the plugin would you accept a PR to also add |
Hey @urbany :) Could you briefly explain what it does? |
I'm not sure, I found this issue when they added the option getsentry/sentry-cli#993 |
Since I found no way to add a test for it I'd like to check out if it actually works before merging this. I will let you know if this PR prevents the build pipeline from failing in case a release commit wasn't found.
Closes #10