Rewrite FindPCRE.cmake #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Phatcat
force-pushed
the
pcre_retried
branch
17 times, most recently
from
06c253c to
0a998ee
Compare
Complete rewrite of FindPCRE.cmake module from scratch; - Properly allocate both release and debug libraries - Automatically prefer static libraries if found - Properly check the set required version and use find_package_handle_standard_Args to throw an error if the version isn't matching or higher than requested - Report which library (or several) are in use and if they're static or shared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete rewrite of FindPCRE.cmake module from scratch;
full static set -> static release -> full shared set -> shared release
Reported by the buildbot:
#16 0.557 -- Found PCRE: /usr/include (found suitable version "8.39", minimum required is "8.39")
#16 0.557 -- Using PCRE static release and debug libraries.
This is a proposed alternative to #92