Skip to content

Conversation

Hadatko
Copy link
Member

@Hadatko Hadatko commented Aug 14, 2023

Ability to receive message in two buffers

Pull request

Choose Correct

  • bug
  • feature

Describe the pull request

#372

To Reproduce

send message from serial side to rpmsg tty side.

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS:
  • eRPC Version:

Steps you didn't forgot to do

  • I checked if other PR isn't solving this issue.
  • I read Contribution details and did appropriate actions.
  • PR code is tested.
  • PR code is formatted.
  • Allow edits from maintainers pull request option is set (recommended).

Additional context

Ability to receive message in two buffers

Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@Hadatko Hadatko added the bug label Aug 14, 2023
@Hadatko Hadatko added this to the 1.12.0 milestone Aug 14, 2023
@Hadatko Hadatko requested a review from MichalPrincNXP August 14, 2023 10:40
@Hadatko Hadatko self-assigned this Aug 14, 2023
@Hadatko
Copy link
Member Author

Hadatko commented Aug 14, 2023

@MichalPrincNXP This should be ready for merge.

@amgross
Copy link
Contributor

amgross commented Aug 14, 2023

Just curious, why the casting to void of functions needed (for example the memcpy)?

I know that doing it to variables is for 'dummy' readings them, but why reading their return code needed?

@Hadatko
Copy link
Member Author

Hadatko commented Aug 14, 2023

Hi @amgross , for example when you have misra, it will complain that you don't check for return values (same like variable which is not used). This way you are informing compiler that you are doing it on purpose.

@Hadatko
Copy link
Member Author

Hadatko commented Sep 18, 2023

I think this is ready. Can you review it @MichalPrincNXP ?

Copy link
Member

@MichalPrincNXP MichalPrincNXP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be ok, but I am not able to try it on any example. Did you have a chance to try it in any erpc app?

@Hadatko
Copy link
Member Author

Hadatko commented Sep 18, 2023

Locally i did. But i had a bit different code than this.
+- it is same, but i am missing some official code and i have some extensions which is not present in official relese.

@MichalPrincNXP
Copy link
Member

I see, ok, we can accept that. Thank you.

@MichalPrincNXP MichalPrincNXP merged commit 9fb5763 into EmbeddedRPC:develop Sep 19, 2023
@Hadatko Hadatko deleted the feature/fix_rpmsg_tty branch September 19, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

[QUESTION] Codec/FramedTransport for header inside message buffer [FEATURE] Read and write the message just by message buffer memory space

3 participants