Skip to content

Conversation

Hadatko
Copy link
Member

@Hadatko Hadatko commented Nov 23, 2022

Signed-off-by: Cervenka Dusan cervenka@acrios.com

Pull request

Choose Correct

  • bug
  • feature

Describe the pull request

safer as prevent passing nullptr

To Reproduce

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS:
  • eRPC Version:

Steps you didn't forgot to do

  • I checked if other PR isn't solving this issue.
  • I read Contribution details and did appropriate actions.
  • PR code is tested.
  • PR code is formatted.
  • Allow edits from maintainers pull request option is set (recommended).

Additional context

-- safer as prevent passing nullptr

Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@Hadatko Hadatko added this to the 1.11.0 milestone Nov 23, 2022
@Hadatko Hadatko self-assigned this Nov 23, 2022
@Hadatko
Copy link
Member Author

Hadatko commented Nov 23, 2022

@MichalPrincNXP i think this one can be merged.

Copy link
Member

@MichalPrincNXP MichalPrincNXP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please

  • resolve conflicts
  • update comments in individual changed functions description (params order)

…parameter_by_reference

Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@Hadatko Hadatko force-pushed the feature/parameter_by_reference branch from 1982c50 to 97271a1 Compare January 24, 2023 14:28
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@MichalPrincNXP MichalPrincNXP merged commit 4c120bb into EmbeddedRPC:develop Jan 26, 2023
@MichalPrincNXP
Copy link
Member

Thank you for the effort and the patience!

@Hadatko Hadatko deleted the feature/parameter_by_reference branch January 26, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants