Skip to content

Conversation

Hadatko
Copy link
Member

@Hadatko Hadatko commented Feb 25, 2022

It doesn't make sense to have portMaxDelay and then recalculate to lower value. Currently other ports are using simple implementation so i align with that.

Signed-off-by: Cervenka Dusan cervenka@acrios.com

It doesn't make sense to have portMaxDelay and then recalculate to lower value. Currently other ports are using simple implementation so i align with that.

Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@Hadatko Hadatko added the bug label Feb 25, 2022
@Hadatko Hadatko added this to the 1.9.1 milestone Feb 25, 2022
@Hadatko Hadatko self-assigned this Feb 25, 2022
@Hadatko
Copy link
Member Author

Hadatko commented Feb 25, 2022

Old PR is no more valid as it is in archived repository: #34
It looks like the request is to use full scale timer. Currently all ports are independent and unit is not set.
I think original unit was in us. If we want use common unit we need align all ports.

@MichalPrincNXP what do you think? Maybe we need talk about it more.

@Hadatko
Copy link
Member Author

Hadatko commented Feb 25, 2022

We can also have other function which will count "us" based on OS. But i don't know if it will not be too much complicated, but OS like this would have possibility to use full scale timer. Maybe have two functions. get() (OS indenpendet) and getUs() /get in us/

@Hadatko
Copy link
Member Author

Hadatko commented Mar 10, 2022

@MichalPrincNXP this is not ready to merge. I cannot do it now. But i fixed Freertos. Sleep function is in us so i will do get too and i think i am doing nice compromise there.

Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@Hadatko Hadatko force-pushed the bugfix/semaphore_locks branch from 72f19a1 to 67a7cdd Compare March 10, 2022 18:26
@Hadatko
Copy link
Member Author

Hadatko commented Mar 10, 2022

@MichalPrincNXP now it should be aligned. Do you see any error in code? Most of them i cannot test.

@Hadatko Hadatko closed this Mar 10, 2022
@Hadatko Hadatko reopened this Mar 10, 2022
Copy link
Member

@MichalPrincNXP MichalPrincNXP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. The only thing I would change is the name of the get function parameter, it should stay clear that it deals with timeout, so my proposal is to change it to timeout_usecs. This parameter name should be also changed in erpc_threading_pthreads.cpp to have it unified. Thank you.

Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@Hadatko
Copy link
Member Author

Hadatko commented Mar 18, 2022

Hi @MichalPrincNXP, is it ok now?

@MichalPrincNXP MichalPrincNXP merged commit 9974b80 into EmbeddedRPC:develop Mar 19, 2022
@MichalPrincNXP
Copy link
Member

Thanks, Dusan!

@Hadatko Hadatko deleted the bugfix/semaphore_locks branch March 21, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants