Fix issue #232 by invoking g++ with -Wno-error=free-nonheap-object #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p-object This changes the global CXXFLAGS, since bison generated code in several locations might trigger a false-positive `free-nonheap-object` warning. Signed-off-by: Daniel Otte <d.otte@wut.de>
|
Hi @d-otte, something similar was merged and then reverted once: https://github.com/EmbeddedRPC/erpc/pull/178/files because other builds failed. I think this is correct change, but we need do it to support other compilers/OS too. |
Hadatko
requested changes
Jan 25, 2022
|
@d-otte I implemented the change on your brach. Could you align your branch with develop branch (merge our develop into your PR branch) so we will be able to run builds for this branch? Thank you ;) |
Hadatko
approved these changes
Feb 1, 2022
MichalPrincNXP
approved these changes
Feb 1, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #232 .
This changes the global CXXFLAGS, since bison generated code in several
locations might trigger a false-positive
free-nonheap-objectwarning.This happens with gcc 11 (gcc version 11.2.0 from ubunut 21.10).
Signed-off-by: Daniel Otte d.otte@wut.de