paranoid-2: Allow to compile code with paranoid compiler flags -Wall -Wextra -Wshadow -Werror -pedantic-errors #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ious local
erpc_simple_server.cpp: In member function ‘virtual erpc_status_t erpc::SimpleServer::run(erpc::RequestContext&)’:
erpc_simple_server.cpp:181:23: error: declaration of ‘err’ shadows a previous local [-Werror=shadow]
erpc_status_t err = runInternalBegin(&codec, buff, msgType, serviceId, methodId, sequence);
^~~
erpc_simple_server.cpp:169:19: note: shadowed declaration is here
erpc_status_t err = kErpcStatus_Success;
^~~
|
I will probably be too busy this week to continue improving this one. Please merge as is and I will open a new branch for the next pull request. |
OK, thanks anyway! |
MichalPrincNXP
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
infra/erpc_simple_server.cpp: fix declaration of ‘err’ shadows a prev…ious local
erpc_simple_server.cpp: In member function ‘virtual erpc_status_t erpc::SimpleServer::run(erpc::RequestContext&)’:
erpc_simple_server.cpp:181:23: error: declaration of ‘err’ shadows a previous local [-Werror=shadow]
erpc_status_t err = runInternalBegin(&codec, buff, msgType, serviceId, methodId, sequence);
^~~
erpc_simple_server.cpp:169:19: note: shadowed declaration is here
erpc_status_t err = kErpcStatus_Success;
^~~