[BUG] Compilation issues with ERPC_ALLOCATION_POLICY_STATIC

[Diagano]

Hi,

1. Compilation errors on erpc_arbitrated_client_deinit()\erpc_client_deinit()\erpc_server_deinit(). All 3 have simular failure cause

2. Generated file that has a structure with a string field. The read function fails compilatoin because of call to erpc_malloc(). That is since the include of "erpc_port.h" is under #if ERPC_ALLOCATION_POLICY == ERPC_ALLOCATION_POLICY_DYNAMIC
   
   
   Which was generated from the following struct (This from the IDL) that is later used as input argument:
   
   ...

To Reproduce

#define ERPC_ALLOCATION_POLICY (ERPC_ALLOCATION_POLICY_STATIC)

Is static allocation policy part of the testing?

[Hadatko]

Hi, we are truly missing Static allocation tests. Static allocation case can be used within some basic types in IDL (int, uint mostly). I think this may be our next big challenge after multiple client support. But not sure why arbitrator code is not able to compile. I will check and fix.

[Diagano]

Please note that I gave two issues here, the second one was not addressed by the PR that was closed.
The second issue stems from this template line in c_server_source.template:

#if ERPC_ALLOCATION_POLICY == ERPC_ALLOCATION_POLICY_DYNAMIC
#include <new>
#include "erpc_port.h"
#endif

This is wrong because even in static policy a struct read function, for example, would use a call to erpc_malloc if it holds string or binary content as I have shown in our case. So the generated code excluds the include even though there is use of "erpc_malloc" leads to compilation error.
In my case for now I just manually moved the #include "erpc_port.h" out of the ifdef.

[Hadatko]

@Diagano Second case i exaplained. It is not bug, more it is not implemented feature. We don't want call malloc in when static allocation is used.

[Diagano]

Sorry, I did not see any comment on the second issue.
[Edit] Was now highlighted the part of your comment above. So by that statemnet our current use is not "supported" as we use POLICY_STATIC while using types like string\binary?

So I am missing something, you may not want to but the generator does produce code that uses it. Is there any PR that changed that?
We work with POLICY_STATIC , the generated code I get with for the use of this kind of struct in the ERPC:

struct key_attributes_t
{
    string              key_name;
    key_type_e       key_type;
    uint16 key_size;
}

Results in this in the generated server side struct read function:
data->key_name = (char*) erpc_malloc((key_name_len + 1) * sizeof(char));

But actually that was only first one. Looking at our generated code I see that in server code for every string\binary input\output.
For example
GetVersion(in uint32 version_str_max_length, out string version_str @max_length(version_str_max_length)) -> RetCode_e

has this in the server generated code:
version_str = (char *) erpc_malloc((version_str_max_length + 1) * sizeof(char));

So currently using realse 1.10.0 I had to take out the #include "erpc_port.h" out of the ifdef