Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using rustls-native-certs instead of webpki-roots #15

Merged
merged 1 commit into from
Aug 20, 2023

Conversation

Shnatsel
Copy link
Contributor

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Keep webpki-roots enabled by default, but allow optionally using rustls-native-certs instead.

This is needed for cargo audit which sometimes runs in strange enterprise environments where all HTTPS traffic is intercepted by a MitM proxy, and it's impossible to contact the outside world without using the OS's native HTTPS certificate store.

This is the approach to configuration recommended by @Byron, here: GitoxideLabs/gitoxide#991

I have verified with cargo tree that the features are toggled correctly.

Related Issues

@mergify mergify bot merged commit 1838c83 into EmbarkStudios:main Aug 20, 2023
@Shnatsel Shnatsel deleted the native-certs branch August 20, 2023 17:50
@Shnatsel
Copy link
Contributor Author

Thanks for the quick review!

I'd appreciate a new release with this change sometime next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants