Skip to content

Conversation

oisyn
Copy link
Contributor

@oisyn oisyn commented Aug 17, 2022

This also fixes #907.

@eddyb eddyb marked this pull request as ready for review August 17, 2022 13:03
@eddyb eddyb enabled auto-merge (rebase) August 17, 2022 13:03
@eddyb
Copy link
Contributor

eddyb commented Aug 17, 2022

I think you just need to run cargo compiletest --bless to get the updated diagnostics output.

oisyn added 3 commits August 17, 2022 15:17
Not needed anymore as libc is is no longer giving issues with this nightly version
@eddyb
Copy link
Contributor

eddyb commented Aug 17, 2022

What's going on here, do we automatically use the latest external spirv-tools on macOS?
I might need to play around with CI on main to get a better idea of what we're dealing with.

EDIT: started: https://github.com/EmbarkStudios/rust-gpu/runs/7880218068?check_suite_focus=true
(original was: https://github.com/EmbarkStudios/rust-gpu/runs/7826423572?check_suite_focus=true)

EDIT2: oh yeah you can see the bew-installed version going from 2022.2 to 2022.3.

@Jake-Shadle
Copy link
Member

Yes, if not compiling from source the spirv binaries in PATH are used, so any time the github runners change those binaries there is a risk of breakage.

@eddyb
Copy link
Contributor

eddyb commented Aug 17, 2022

Yes, if not compiling from source the spirv binaries in PATH are used, so any time the github runners change those binaries there is a risk of breakage.

Can't we just pass a version to brew install? These don't even come with GHA, we appear to install them ourselves in CI explicitly.

@Jake-Shadle
Copy link
Member

In that case I guess you could specify the exact version, however one does that with brew.

@eddyb
Copy link
Contributor

eddyb commented Aug 17, 2022

In that case I guess you could specify the exact version, however one does that with brew.

Turns out that one does not do that with brew, and after having my optimism crushed I ended up with:

(which involved digging through the spirv-tools Google Cloud Storage bucket for the right URL...)

@eddyb eddyb merged commit e50606f into main Aug 17, 2022
@eddyb eddyb deleted the new-nightly branch August 17, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Newer libc versions (0.2.113 or later) don't compile with Rust-GPU's rust-toolchain.

3 participants