This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Add an IndexUnchecked trait that uses asm!#805
Merged
khyperia merged 5 commits intoEmbarkStudios:mainfrom Nov 29, 2021
Merged
Conversation
khyperia
suggested changes
Nov 25, 2021
Contributor
|
Also, it'd be nice to not use |
khyperia
approved these changes
Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #803 it became possible to write
asm!functions that index into arrays andRuntimeArrays without bounds checking. This PR exposes these functions as a trait. I decided onindex_unchecked*instead ofget_unchecked*to avoid the name aliasing. It could still be pretty confusing though.