This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Repository navigation
Intercept calls to libm - #264
Merged
Merged
Conversation
eddyb
suggested changes
Nov 20, 2020
eddyb
left a comment
eddyb
left a comment
Contributor
There was a problem hiding this comment.
LGTM, modulo the matching on mangled symbol names.
Contributor
|
(Moved here because GitHub really wanted to show 100 lines of the diff, when it was a diff comment, oops) Looks like the functions are all鹿 鹿exceptions: // math::erf::erfc
// math::erff::erfcf
// math::j0::y0
// math::j0f::y0f
// math::j1::y1
// math::j1f::y1f
// math::jn::yn
// math::jnf::ynf |
khyperia
force-pushed
the
intercept-libm
branch
from
November 20, 2020 14:28
31c91fc to
6b88dd3
Compare
eddyb
suggested changes
Nov 20, 2020
eddyb
left a comment
eddyb
left a comment
Contributor
There was a problem hiding this comment.
r=me with the commented out line removed
| really_unsafe_ignore_bitcasts: Symbol, | ||
| attributes: HashMap<Symbol, SpirvAttribute>, | ||
| execution_modes: HashMap<Symbol, (ExecutionMode, ExecutionModeExtraDim)>, | ||
| pub libm_intrinsics: HashMap<Symbol, libm_intrinsics::LibmIntrinsic>, |
Contributor
There was a problem hiding this comment.
Almost suggested this (but forgot), nice!
eddyb
approved these changes
Nov 20, 2020
Member
|
馃帀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matching on symbol names is probably not the right thing to do here, but I'm not sure what other options there are (
Instance'sDisplayimpl?).This corresponds to a change to our
glamPR to use libm instead ofMathExt. Currently that's at EmbarkStudios/glam-rs@709ac6d and not merged into thespirvPR branch, I'll do so once this is in.