This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Add rustfmt.toml with version = "Two" to enable formatting array patterns.
#1069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repi
approved these changes
Jun 3, 2023
Contributor
repi
left a comment
repi
left a comment
There was a problem hiding this comment.
nice, didn't know about this either. but is another nightly rustfmt feature but sounds fine to use here!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was checking something about SPIR-T CI and realized I'd forgotten I ended up with a
rustfmt.tomlfor SPIR-T that containedversion = "Two"because of this PR:I'm not really sure why a decision was taken to not enable formatting array/slice patterns by default, making them nearly-unusable in non-trivial cases, but this is the result.
You'll notice there's many more changes than just array/slice patterns, looks like
version = "Two"also enables a few more quality-of-life improvements as well, and I'm not sure if it's the direct cause but I was also able to remove some#[rustfmt::skip]s which didn't do anything anymore (see the second commit).