Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unmatched-organization warnings for deny template #688

Merged
merged 1 commit into from
Aug 4, 2024
Merged

Fix unmatched-organization warnings for deny template #688

merged 1 commit into from
Aug 4, 2024

Conversation

Marcono1234
Copy link
Contributor

@Marcono1234 Marcono1234 commented Aug 3, 2024

With the current deny.template.toml https://github.com/EmbarkStudios/cargo-deny-action prints the following warnings:

 warning[unmatched-organization]: allowed 'github.com' organization  was not encountered
    ┌─ ./deny.toml:235:11
    │
235 │ github = [""]
    │           ━ no crate source fell under this organization

warning[unmatched-organization]: allowed 'gitlab.com' organization  was not encountered
    ┌─ ./deny.toml:237:11
    │
237 │ gitlab = [""]
    │           ━ no crate source fell under this organization

warning[unmatched-organization]: allowed 'bitbucket.org' organization  was not encountered
    ┌─ ./deny.toml:239:14
    │
239 │ bitbucket = [""]
    │              ━ no crate source fell under this organization

Note: I have marked this as draft for now because I am not sure if the approach of changing the documentation to allow 0 Git sources is good here; an alternative would be to just comment out github = ["..."], ...
Though it seems 0 Git sources are currently permitted, see also #689.

@Marcono1234 Marcono1234 marked this pull request as ready for review August 3, 2024 19:59
@Marcono1234 Marcono1234 marked this pull request as draft August 3, 2024 19:59
@Jake-Shadle Jake-Shadle marked this pull request as ready for review August 4, 2024 06:37
@Jake-Shadle Jake-Shadle merged commit e399f29 into EmbarkStudios:main Aug 4, 2024
1 check passed
@Marcono1234 Marcono1234 deleted the unmatched-organization-warning branch August 4, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants