Fix clippy lints

src/bans/mod.rs

@@ -339,9 +339,7 @@ pub fn check(
             // can cleanup their configs as their dependency graph changes over time
             skip_hit.as_mut_bitslice().set(index, true);
         } else if !tree_skipper.matches(krate, &mut pack) {
-            if multi_detector.name == krate.name {
-                multi_detector.dupes.push(i);
-            } else {
+            if multi_detector.name != krate.name {
                 if multi_detector.dupes.len() > 1 && multiple_versions != LintLevel::Allow {
                     let severity = match multiple_versions {
                         LintLevel::Warn => Severity::Warning,
@@ -419,9 +417,10 @@ pub fn check(
 
                 multi_detector.name = &krate.name;
                 multi_detector.dupes.clear();
-                multi_detector.dupes.push(i);
             }
 
+            multi_detector.dupes.push(i);
+
             if wildcards != LintLevel::Allow {
                 let severity = match wildcards {
                     LintLevel::Warn => Severity::Warning,

src/licenses/cfg.rs

@@ -363,7 +363,7 @@ mod test {
         assert!(diags.is_empty());
 
         assert_eq!(validated.file_id, cd.id);
-        assert_eq!(validated.private.ignore, true);
+        assert!(validated.private.ignore);
         assert_eq!(validated.private.registries, vec!["sekrets".to_owned()]);
         assert_eq!(validated.unlicensed, LintLevel::Warn);
         assert_eq!(validated.copyleft, LintLevel::Deny);

src/licenses/gather.rs

@@ -192,7 +192,7 @@ impl LicensePack {
         // Add the explicitly specified license if it wasn't
         // already found in the root directory
         if let Some(ref lf) = krate.license_file {
-            if lic_paths.iter().find(|l| l.ends_with(lf)).is_none() {
+            if !lic_paths.iter().any(|l| l.ends_with(lf)) {
                 // The `krate.license_file` is relative to the crate, while files found with
                 // `find_license_files()` are absolute. We prepend the directory of the current
                 // crate, to make sure all license file paths will be absolute.

src/manifest/dependency.rs

@@ -70,7 +70,7 @@ impl Dependency {
 
         let (old_path, old_registry) = match self.source {
             DependencySource::Version { path, registry, .. } => (path, registry),
-            _ => (None, None),
+            DependencySource::Git { .. } => (None, None),
         };
         self.source = DependencySource::Version {
             version: Some(version),
@@ -93,7 +93,7 @@ impl Dependency {
     pub fn set_path(mut self, path: &str) -> Dependency {
         let old_version = match self.source {
             DependencySource::Version { version, .. } => version,
-            _ => None,
+            DependencySource::Git { .. } => None,
         };
         self.source = DependencySource::Version {
             version: old_version,
@@ -143,7 +143,7 @@ impl Dependency {
     pub fn set_registry(mut self, registry: &str) -> Dependency {
         let old_version = match self.source {
             DependencySource::Version { version, .. } => version,
-            _ => None,
+            DependencySource::Git { .. } => None,
         };
         self.source = DependencySource::Version {
             version: old_version,
@@ -237,8 +237,7 @@ impl Dependency {
                     data.get_or_insert("optional", optional);
                 }
                 if let Some(features) = features {
-                    use std::iter::FromIterator;
-                    let features = toml_edit::Value::from_iter(features.iter().cloned());
+                    let features: toml_edit::Value = features.iter().cloned().collect();
                     data.get_or_insert("features", features);
                 }
                 if !self.default_features {