Profile extension fixed serialization #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| /** | ||
| * @covers ::load |
There was a problem hiding this comment.
Travis is giving a problem because this test doesn't cover a \EmanueleMinotto\TwigCacheBundle\Twig\ProfilerExtension::load method.
Replace it with:
/**
* @covers ::serialize
* @covers ::unserialize
*/
|
All checks have passed now :) |
EmanueleMinotto
added a commit
that referenced
this pull request
Oct 4, 2015
Profile extension fixed serialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got lots of 404 for _wdt/{token} (Web Profiler) and figured out, that it will throw an exception when the ProfilerExtension of this bundle will be serialized ("Serialization of closures is not supported").
So i added a Serializable-Interface to force only the serialization of getData() and not the whole object. The Web Profiler Toolbar is now working again :)