Merged
Conversation
fbacall
requested changes
Jun 25, 2025
Member
fbacall
left a comment
There was a problem hiding this comment.
Code looks good - could you add a test for this?
Here's an example of a test for the XML sitemap: https://github.com/ElixirTeSS/TeSS/blob/master/test/unit/ingestors/bioschemas_ingestor_test.rb#L39-L97
It does not have to be as complex as that though, just something simple that will trigger the txt sitemap parsing code
0406710 to
20bceb2
Compare
fbacall
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1118
Summary of changes
Motivation and context
Screenshots
Checklist
to license it to the TeSS codebase under the
BSD license.