Skip to content

Fix unhandled exception to non-existent instance of MSSQL-EXPRESS installed #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Fix unhandled exception to non-existent instance of MSSQL-EXPRESS installed #9

merged 1 commit into from
Nov 13, 2018

Conversation

gpgpublickey
Copy link
Contributor

This issue crash the builds if you don't have mssqlexpress instances running on the OS.
poc2

and when you try to run in debug mode.
poc

@bleglaiger
Copy link

image
(My englis is bad)

I have installed SQL SERVER in my PC.

@gpgpublickey
Copy link
Contributor Author

I can understand but I think it's a good idea to implement a fix to handle the normal behavior of the app and catch the exception when you are not using the recommended sql engine.

@gpgpublickey
Copy link
Contributor Author

gpgpublickey commented Mar 29, 2018

@jsperk Could you please review my pull request?

@isperk isperk merged commit 6bd87d4 into ElevenPaths:master Nov 13, 2018
@isperk
Copy link
Contributor

isperk commented Nov 13, 2018

@jsperk Could you please review my pull request?

Its done!!! sorry for the lag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants