Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eval harness fix #457

Merged
merged 4 commits into from
Nov 7, 2021
Merged

Eval harness fix #457

merged 4 commits into from
Nov 7, 2021

Conversation

sdtblck
Copy link
Contributor

@sdtblck sdtblck commented Nov 7, 2021

This fixes some problems relating to eval harness & model parallel models.
To summarize:

  • logits weren't being gathered automatically, so with a model parallel size of 2, each machine only had vocab_size / 2 logits, which resulted in indexing errors.
  • There was no straightforward way to toggle whether the logits were gathered or not, now there is (model._set_parallel_output(value))
  • When zero optimization was being used in a config, it would break at inference time. Fixed this by overriding the zero config when setting up for inference (https://github.com/EleutherAI/gpt-neox/compare/eval_harness_fix?expand=1#diff-b6ee2c1db780b46787ab3a576020f9a12695f3f5cb38ba8badcd5501960e5d22R409)
  • There was no way to specify which tasks to run on the command line at runtime, you would have to specify them in the yaml config. Now you can do ./deepy.py evaluate.py -d configs 20B --eval_tasks lambada wikitext hellaswag
  • Fixes some minor spelling errors (adaptor vs. adapter)

@sdtblck sdtblck requested a review from a team as a code owner November 7, 2021 15:11
EricHallahan
EricHallahan previously approved these changes Nov 7, 2021
@sdtblck sdtblck merged commit 74afd1b into main Nov 7, 2021
@sdtblck sdtblck deleted the eval_harness_fix branch November 7, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants