Open
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
1 similar comment
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
luciaquirke
force-pushed
the
tokens
branch
3 times, most recently
from
226ff18 to
07d8441
Compare
Contributor
|
Looking forward to token filtering and think this is pretty important - have use cases for it! |
Collaborator
Author
Yep will do |
luciaquirke
force-pushed
the
tokens
branch
8 times, most recently
from
1d64cd9 to
e4011d0
Compare
…g, clean up configs - Rewrite auto_batch_size to use simpler halving strategy instead of complex binary search - Simplify allocate_batches by removing _allocate_batches_world indirection - Remove unused hessian-related config fields and collector hooks - Add load_from_disk support for Arrow datasets in data pipeline - Clean up imports, logging, docs, and CLI help text - Remove deprecated math utilities and unused score_writer functionality Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
… loading, clean up configs
luciaquirke
force-pushed
the
tokens
branch
6 times, most recently
from
b562ada to
641b641
Compare
luciaquirke
force-pushed
the
tokens
branch
3 times, most recently
from
cb86731 to
17f1f98
Compare
Collaborator
Author
|
@LouisYRYJ cleaned up |
Contributor
|
sweet, will take a look today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.